Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update third-party-tools.rst #808

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Update third-party-tools.rst #808

merged 3 commits into from
Jun 25, 2018

Conversation

anhldbk
Copy link
Contributor

@anhldbk anhldbk commented May 29, 2018

Added Java Locust Swarm client

@anhldbk
Update third-party-tools.rst
fce34ad 
Added Java Locust Swarm client
@codecov
Copy link

codecov bot commented May 29, 2018 •
edited
Loading

Codecov Report

Merging #808 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   65.11%   65.11%           
=======================================
  Files          14       14           
  Lines        1422     1422           
  Branches      224      224           
=======================================
  Hits          926      926           
  Misses        444      444           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b1e80...9d2b5a0. Read the comment docs.

ps-george
ps-george reviewed May 30, 2018
View reviewed changes
Copy link
Contributor

@ps-george ps-george left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could put it under your own heading, is there a reason you put it under the same heading as Locust4j?

@anhldbk
Copy link
Contributor Author

anhldbk commented May 30, 2018

@ps-george I'm sorry. What do you think about the idea of grouping clients based on their languages? If we don't need that, then I add another heading for my client

@ps-george
Copy link
Contributor

I think it's a good idea to group clients by languages 👍

@anhldbk
Update third-party-tools.rst
89f7b19 
Categorized clients by their programming languages
@anhldbk
Copy link
Contributor Author

anhldbk commented May 30, 2018

@ps-george ps I updated

cgoldberg
cgoldberg suggested changes May 30, 2018
View reviewed changes
Copy link
Member

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change the description to "Swarm is a Locust slave runner written in Java." and remove the bit about being "elegant".

@anhldbk
Copy link
Contributor Author

anhldbk commented May 30, 2018

@cgoldberg Pls have a look at the new commit

@anhldbk
Copy link
Contributor Author

anhldbk commented Jun 24, 2018

@cgoldberg Is this PR ok?

@aldenpeterson-wf
Copy link
Contributor

LGTM

@aldenpeterson-wf aldenpeterson-wf merged commit 98f213a into locustio:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-george ps-george ps-george left review comments

@cgoldberg cgoldberg cgoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anhldbk @ps-george @aldenpeterson-wf @cgoldberg